ext/snmp: Retry no-response test failures - #23237
Draft
LamentXU123 wants to merge 3 commits into
Draft
Conversation
LamentXU123
changed the title
is_flaky_output in flaky SNMP tests
LamentXU123
marked this pull request as draft
August 12, 2026 18:59
LamentXU123
changed the title
is_flaky_output in flaky SNMP tests
LamentXU123
marked this pull request as ready for review
August 12, 2026 19:12
LamentXU123
marked this pull request as draft
August 12, 2026 21:30
NickSdot
reviewed
Aug 13, 2026
| 'connection refused', | ||
| 'deadlock', | ||
| 'mailbox already exists', | ||
| 'no response from', |
Contributor
There was a problem hiding this comment.
Could we add a comment why it was added? Harder to follow via git history. Ideally the list shrinks to zero later; most of it sounds like concurrency stuff which we eventually might rather want to find root causes instead of adding retry overhead.
Member
There was a problem hiding this comment.
Talking to external services is inherently flaky.
Contributor
There was a problem hiding this comment.
Doesn't mean it's the sole reason. Still think adding a comment why, as in which context, it was deemed necessary to add makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the SNMP retry pattern to
is_flaky_outputto retry SNMP tests when it fails.This also removes the XFAIL section in SNMP tests.
Note: only snmp tests use the
No response from ...prefix